tudor/school_compare
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request 'fix(compare): keep chart data when a client refetch fails' (#12) from fix/compare-chart-refetch-resilience into main
Deploy (staging -> E2E gate -> production) / Build Backend (FastAPI) (push) Successful in 16s
Details
Deploy (staging -> E2E gate -> production) / Build Frontend (Next.js) (push) Successful in 47s
Details
Deploy (staging -> E2E gate -> production) / Build Pipeline (Meltano + dbt + Airflow) (push) Successful in 12s
Details
Deploy (staging -> E2E gate -> production) / Deploy to Staging (push) Successful in 1s
Details
Deploy (staging -> E2E gate -> production) / E2E Journeys against Staging (push) Failing after 1m9s
Details
Deploy (staging -> E2E gate -> production) / Promote to Production (push) Has been skipped
Details

Browse Source 
Reviewed-on: #12
This commit was merged in pull request #12.
This commit is contained in:
tudor
2026-07-06 07:27:03 +00:00
parent 18cd805c6c 9f8dba227c
commit 694b6013b3
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
nextjs-app/components/ComparisonView.tsx
+3 -1
View File
@@ -111,8 +111,10 @@ export function ComparisonView({
setComparisonData(data.comparison); setComparisonData(data.comparison);
}) })
.catch((err) => { .catch((err) => {
// Keep whatever we already have (SSR data or a previous fetch) rather
// than blanking the chart — a transient refetch failure shouldn't
// destroy a working comparison the user is looking at.
console.error('Failed to fetch comparison:', err); console.error('Failed to fetch comparison:', err);
setComparisonData(null);
}); });
} else { } else {
setComparisonData(null); setComparisonData(null);