From 684da611ff11d3582d05a92b45b6f2400175f54f Mon Sep 17 00:00:00 2001 From: Tudor Date: Fri, 24 Jul 2026 09:24:27 +0100 Subject: [PATCH] feat(detail): always show religious character, "None" for no religious character Previously the chip was hidden for "Does not apply"/"None". Show it in all cases, rendering "None" for those two sentinel values. Co-Authored-By: Claude Opus 4.8 --- nextjs-app/components/SchoolDetailView.tsx | 9 ++++++--- nextjs-app/components/SecondarySchoolDetailView.tsx | 9 ++++++--- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/nextjs-app/components/SchoolDetailView.tsx b/nextjs-app/components/SchoolDetailView.tsx index 85e0e22..adca63c 100644 --- a/nextjs-app/components/SchoolDetailView.tsx +++ b/nextjs-app/components/SchoolDetailView.tsx @@ -354,9 +354,12 @@ export function SchoolDetailView({ {schoolInfo.age_range && ( {formatAgeRange(schoolInfo.age_range)} )} - {schoolInfo.religious_denomination - && !['Does not apply', 'None'].includes(schoolInfo.religious_denomination) && ( - {schoolInfo.religious_denomination} + {schoolInfo.religious_denomination && ( + + {['Does not apply', 'None'].includes(schoolInfo.religious_denomination) + ? 'None' + : schoolInfo.religious_denomination} + )} {schoolInfo.nursery_provision && ( Nursery diff --git a/nextjs-app/components/SecondarySchoolDetailView.tsx b/nextjs-app/components/SecondarySchoolDetailView.tsx index 910d414..1304a36 100644 --- a/nextjs-app/components/SecondarySchoolDetailView.tsx +++ b/nextjs-app/components/SecondarySchoolDetailView.tsx @@ -246,9 +246,12 @@ export function SecondarySchoolDetailView({ {schoolInfo.age_range && ( {formatAgeRange(schoolInfo.age_range)} )} - {schoolInfo.religious_denomination - && !['Does not apply', 'None'].includes(schoolInfo.religious_denomination) && ( - {schoolInfo.religious_denomination} + {schoolInfo.religious_denomination && ( + + {['Does not apply', 'None'].includes(schoolInfo.religious_denomination) + ? 'None' + : schoolInfo.religious_denomination} + )} {schoolInfo.nursery_provision && ( Nursery