fix(list/map): badge report-card schools as Report Card, not their carried-forward grade · 5ec4f3f7cd - school_compare

fix(list/map): badge report-card schools as Report Card, not their carried-forward grade

PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 1m5s

Details

PR Checks / Backend Smoke (pull_request) Successful in 7s

Details

PR Checks / Build Backend (no push) (pull_request) Successful in 17s

Details

PR Checks / Build Frontend (no push) (pull_request) Successful in 47s

Details

PR Checks / Build Pipeline (no push) (pull_request) Successful in 10s

Details

PR Checks / AI Code Review (Claude) (pull_request) Successful in 2m48s

Details

The search-result cards and map pins keyed report-card detection off
ofsted_framework === 'ReportCard', but the API sets ofsted_framework to the
raw event grouping ('Schools - S5'); worse, ofsted_grade (the carried-forward
legacy grade) was checked first and won. So report-card schools were badged
by their old grade — Barclay's pin/card read 'Outstanding · 2021' instead of
'Report Card · 2026'. Same root cause as the detail-page fix, different
surface.

Expose ofsted_rc_date on the list serialization (the report-card inspection
date, non-null only for report cards) and make both badge builders treat a
present rc-date as winning over any grade, using its year. Removes the dead
framework === 'ReportCard' branches.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB

This commit is contained in:

Tudor

2026-07-18 21:14:57 +01:00

co-authored by

Claude Fable 5

parent 74bdbebd57

commit 5ec4f3f7cd

7 changed files with 64 additions and 11 deletions

									
										backend/schemas.py
									
		+1
		
												View File
												
				@@ -550,6 +550,7 @@ SCHOOL_COLUMNS = [

				    "ofsted_grade",

				    "ofsted_date",

				    "ofsted_framework",

				    "ofsted_rc_date",

				    "latitude",

				    "longitude",

				]