fix(brand): match the below-average tint to its own hue, and finish the casing · 39e5c11274 - school_compare

fix(brand): match the below-average tint to its own hue, and finish the casing

PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 1m2s

Details

PR Checks / Backend Smoke (pull_request) Successful in 6s

Details

PR Checks / Build Backend (no push) (pull_request) Successful in 10s

Details

PR Checks / Build Frontend (no push) (pull_request) Successful in 43s

Details

PR Checks / Build Pipeline (no push) (pull_request) Successful in 10s

Details

PR Checks / AI Code Review (Claude) (pull_request) Successful in 3m19s

Details

Three review findings.

--status-below-bg carried the raw --coral tuple (249,115,96) instead of the
hue it belongs to (#A9481F → 169,72,31), so "below average" chips rendered a
coral-pink wash behind terracotta text — the one solid/tint pair in the file
whose hues disagreed. Alpha drops 0.15 → 0.12 to match --status-above-bg, so
the two chips read as equal weight; left at 0.15 the darker terracotta tint
takes the label to 4.45:1 on Warm White, under the 4.5 floor. At 0.12 it is
4.86:1 on cards and 4.67:1 on Warm White.

Auditing the whole file for the same class of error turned up one more:
--action-bg was also a --coral tint while --action is the darkened #BE3C27.
It is unused today and the dark-theme value was already correct, but it is
aligned so a future coral ghost button gets a matching label and ground. The
five phase pairs also "mismatch" by the same test and are deliberately left
alone: those pair a pastel ground (sage, sky, mustard, lavender) with a deeper
text hue, which is exactly what the guideline's Chips/Tags show.

The lowercase wordmark had only reached the visual chrome. Every user-visible
occurrence now matches: page title and template, appleWebApp title, authors,
OpenGraph and Twitter titles and siteName, the school page's siteName, the PWA
manifest name and short_name, the footer copyright line, the nav's aria-label,
the Web Share API strings, and the editorial paragraph. Comments in lib/*.ts
and AdmissionsView still say "SchoolCompare"; they describe the codebase rather
than the mark, so they are left to keep this diff to the reported problem.

The comment explaining why the font classes belong on <html> still described
--font-schibsted, which no longer exists. It now names --font-manrope and
--font-inter, and records that the e2e typeface assertion is the only guard —
this failure mode throws nothing and fails no unit test.

Verified: tsc clean, 159/159 tests, build green, and the rendered title is now
"School Admissions Guide | schoolcompare". Status and phase labels re-checked
on their own composited tints over both light grounds — all clear AA.

This commit is contained in:

Tudor

2026-08-07 18:33:30 +01:00

parent accc562b90

commit 39e5c11274

8 changed files with 34 additions and 25 deletions

									
										nextjs-app/components/EditorialSection.tsx
									
		+1
		-1
	
												View File
												
				@@ -20,7 +20,7 @@ export function EditorialSection({ totalSchools, localAuthorityCount }: Editoria

				            and demographics — each in its own table, each with its own jargon.

				          </p>

				          <p>

				            SchoolCompare brings it all into one place. Every school page shows performance against the national

				            schoolcompare brings it all into one place. Every school page shows performance against the national

				            average, explains what the numbers mean, and lets you shortlist schools side by side. Built for

				            parents, governors, journalists, and anyone who wants to understand a school without reading a

				            full inspection report.