tudor/school_compare
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(api): map blank-name GIAS sentinel codes to empty string, not Unknown
PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 9m40s
Details
PR Checks / Backend Smoke (pull_request) Successful in 7s
Details
PR Checks / Build Backend (no push) (pull_request) Successful in 20s
Details
PR Checks / Build Frontend (no push) (pull_request) Successful in 54s
Details
PR Checks / Build Pipeline (no push) (pull_request) Successful in 37s
Details
PR Checks / AI Code Review (Claude) (pull_request) Successful in 2m35s
Details

Browse Source 
ReligiousCharacter 99 (~4k schools) and AdmissionsPolicy 9 (~5.6k) carry a
code with a blank name in the GIAS CSV; the generator skipped them so they
hit the Unknown(<code>) path — wrongly triggering the Faith-priority tag
and polluting filters. Blank-only codes now map to "" (byte-identical to
the old name pipeline); accepted_values lists extended to match the seed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Tudor
2026-07-09 22:04:53 +01:00
co-authored by Claude Fable 5
parent 84dfc6c1bb
commit 3710529e49
6 changed files with 38 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pipeline/transform/models/marts/_marts_schema.yml
+2 -2
View File
@@ -42,12 +42,12 @@ models:
tests:
- accepted_values:
severity: warn
values: [0, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 24, 25, 26, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49]
values: [0, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 24, 25, 26, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 99]
- name: admissions_policy_code
tests:
- accepted_values:
severity: warn
values: [0, 2, 4]
values: [0, 2, 4, 9]
- name: dim_location
description: School location dimension with PostGIS geometry