From 109fa14ccb90425096df8b01c06335959243baf0 Mon Sep 17 00:00:00 2001
From: Tudor Sitaru <tudor.sitaru@gmail.com>
Date: Thu, 9 Apr 2026 16:04:41 +0100
Subject: [PATCH] fix(secondary): use GIAS total_pupils for school roll, not
 KS4 exam cohort

latestResults.total_pupils in KS4 data is the Year 11 exam cohort (~1/7
of the school), not the full school roll. Prefer schoolInfo.total_pupils
(sourced from GIAS NumberOfPupils) which is the statutory census headcount.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 nextjs-app/components/SecondarySchoolDetailView.tsx | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/nextjs-app/components/SecondarySchoolDetailView.tsx b/nextjs-app/components/SecondarySchoolDetailView.tsx
index 00e124a..624b128 100644
--- a/nextjs-app/components/SecondarySchoolDetailView.tsx
+++ b/nextjs-app/components/SecondarySchoolDetailView.tsx
@@ -215,9 +215,9 @@ export function SecondarySchoolDetailView({
                   </a>
                 </span>
               )}
-              {latestResults?.total_pupils != null && (
+              {(schoolInfo.total_pupils != null || latestResults?.total_pupils != null) && (
                 <span className={styles.headerDetail}>
-                  <strong>Pupils:</strong> {latestResults.total_pupils.toLocaleString()}
+                  <strong>Pupils:</strong> {(schoolInfo.total_pupils ?? latestResults!.total_pupils!).toLocaleString()}
                   {schoolInfo.capacity != null && ` (capacity: ${schoolInfo.capacity})`}
                 </span>
               )}
@@ -716,10 +716,10 @@ export function SecondarySchoolDetailView({
                     <div className={styles.metricHint}>Education, Health and Care Plan</div>
                   </div>
                 )}
-                {latestResults?.total_pupils != null && (
+                {(schoolInfo.total_pupils != null || latestResults?.total_pupils != null) && (
                   <div className={styles.metricCard}>
                     <div className={styles.metricLabel}>Total pupils</div>
-                    <div className={styles.metricValue}>{latestResults.total_pupils.toLocaleString()}</div>
+                    <div className={styles.metricValue}>{(schoolInfo.total_pupils ?? latestResults!.total_pupils!).toLocaleString()}</div>
                     {schoolInfo.capacity != null && (
                       <div className={styles.metricHint}>Capacity: {schoolInfo.capacity}</div>
                     )}